• Andrei Borzenkov's avatar
    support modules without symbol table · 67dba97e
    Andrei Borzenkov authored
    all_video module does not have any code or data and exists solely for
    .moddeps section to pull in dependencies. This makes all symbols unneeded.
    
    While in current binutils (last released version as of this commit is 2.26)
    ``strip --strip-unneeded'' unintentionally adds section symbols for each
    existing section, this behavior was considered a bug and changed in commit
    14f2c699ddca1e2f706342dffc59a6c7e23e844c to completely strip symbol table
    in this case.
    
    Older binutils (verified with 2.17) and some other toolchains (at least
    elftoolchain r3223M), both used in FreeBSD, remove symbol table in all_video
    as well.
    
    Relax run-time check and do not return error for modules without symbol table.
    Add additional checks to module verifier to make sure such modules
    
    a) have non-empty .moddeps section. Without either externally visible symbols
    or .moddeps modules are completely useless and should not be built.
    
    b) do not have any relocations.
    
    Closes: 46986
    
    v2: add run-time check for empty symbol table if relocations are present as
        suggested by Vladimir.
    67dba97e