So that we can use it in grub-emu as well as utils.

clang as incomplete mcmodel=large support. As we don't currently need full
mcmodel=large support for sparc64, relax those checks.

Check that they point to the same module, so will end up in the same
chunk of memory.

Currently only Windows gets distinguished icons, everything else is displayed
using the same generic one. Add additional --class based on os-prober returned
label, which usually is expected to match primary distribution name.

Also use it for Windows as well - chainloader prober may actually return
different strings (Windows, MS-DOS, Windows9xME).

Reported by: Thomas Schmitt

Brackets detection was copied from somewhere else and makes no sense in case
of grub-mount and prevents user from accessing and files with ) in them.

This did not cause real problem but is good for reproducible builds. I hit
it with recent bootinfoscript that displays embedded config; I was puzzled
by random garbage at the end.

Prezero memory buffer used to assemble core.img. This makes individual
memset redundant. Also ensure buffer is filled with zeroes in several other
places.

Also remove redundant zeroing code where we fill in the whole memory block
anyway.

Incorrect drive name was being passed into grub_util_sparc_setup,
causing the grub-install to fail.
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>

r+ does not create a file if none exists.

Found by: Coverity scan.
CID: 73772

Current code in probe() could not be verified to not contain memory leaks.
Restructure code and ensure grub_device_close is always called at the end of
loop.

Calms down Coverity scan.
CID: 73739

grub_util_{info,warn,error} already add trailing newlines, so remove
them from format strings. Also trailing full stops are already added.

This helps us to be in line with xorriso -as mkisofs.

Suggested by: Thomas Schmitt

Otherwise scripts will source wrong grub-mkconfig_lib.

It clashhes with -V which is alias to -volid.

canonicalize_file_name clashed with gnulib function. Additionally
it was declared in 2 places: emu/misc.h and util/misc.h. Added
grub_ prefix and removed second declaration.

gcc5 reports:
../util/mkimage.c: In function 'grub_install_get_image_target':
../util/mkimage.c:954:5: error: loop exit may only be reached after undefined behavior [-Werror=aggressive-loop-optimizations]
     && j < ARRAY_SIZE (image_targets[i].names); j++)
     ^
../util/mkimage.c:953:39: note: possible undefined statement is here
      for (j = 0; image_targets[i].names[j]
                                        ^

Well, let's move the index 'j' test before accesing the array to:
1) make the loop obvious
2) make gcc happy
Signed-off-by: Jiri Slaby <jslaby@suse.cz>

Found by: Coverity scan.

Found by: Coverity scan.

Move fatal check whether symtab_section is NULL before first reference.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.

Found by: Coverity scan.